-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(lint): mixedCase exceptions #11330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, could you please add a test for a custom defined exception and for IERC
as well? Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 👍
ref:
mixed-case-function
support fn patterns like ERC #11325mixed-case-function
rule when referring to constant functions in interface #11315Solution
introduces the concept of
lint::LinterConfig
(which includes the pre-existingInlineConfig
toLintContext
, so that we can have lint-specific config.once we have custom configs for more lints,
config::LinterConfig
should probably have a dedicated struct to encapsulate all of them in a single field. For the time being,mixed_cased_exceptions
has been created.