Skip to content

Conversation

0xrusowsky
Copy link
Contributor

@0xrusowsky 0xrusowsky commented Aug 18, 2025

ref:

Solution

introduces the concept of lint::LinterConfig (which includes the pre-existing InlineConfig to LintContext, so that we can have lint-specific config.

once we have custom configs for more lints, config::LinterConfig should probably have a dedicated struct to encapsulate all of them in a single field. For the time being, mixed_cased_exceptions has been created.

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, could you please add a test for a custom defined exception and for IERC as well? Thank you

@grandizzy grandizzy self-requested a review August 19, 2025 06:27
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👍

@grandizzy grandizzy merged commit 3e32767 into master Aug 20, 2025
22 checks passed
@grandizzy grandizzy deleted the rusowsky/mixed-case-exceptions branch August 20, 2025 12:34
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants