feat(cast): wallet sign-auth --self-broadcast #12624
Open
+110
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xferrous
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Add a new option `--self-broadcast` to indicate the signed authorization is intended to be broadcasted by the signing account. This is used to determine the nonce for the authorization that will be valid for the broadcasting transaction. If the signing account itself broadcasts the authorization, the nonce is incremented and the authorization becomes invalid if it is signed for the `next_nonce` instead of `next_nonce + 1`.
0xferrous
force-pushed
the
push-kwqpqnkrpmur
branch
from
00da7d9 to
83accfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the signing account itself broadcasts the authorization, the nonce is incremented and the authorization becomes invalid if it is signed for the
next_nonceinstead ofnext_nonce + 1.Solution
Add a new option
--self-broadcastto indicate the signed authorization is intended to be broadcasted by the signing account. This is used to determine the nonce for the authorization that will be valid(i.e.next_nonce + 1) for the broadcasting transaction.PR Checklist