feat(cast): batch send/sign/mktx in cast #13000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
requested changes
Jan 6, 2026
crates/cast/src/cmd/batch_send.rs
Outdated
Comment on lines
38
to
45
| /// Parsed transaction specification | ||
| #[derive(Debug, Clone)] | ||
| pub struct TxSpec { | ||
| pub to: String, | ||
| pub value: Option<String>, | ||
| pub sig: Option<String>, | ||
| pub args: Vec<String>, | ||
| } |
Member
There was a problem hiding this comment.
are these parsed differently?
if not we can unify them and avoid duplicating parsing
| /// | ||
| /// Examples: | ||
| /// --tx "0x123:0.1ether" (ETH transfer) | ||
| /// --tx "0x456::transfer(address,uint256):0x789,1000" (contract call) |
Member
There was a problem hiding this comment.
can we add some clap test for this, because I believe the signature must be wrapped in a string due to the ,?
Contributor
Author
There was a problem hiding this comment.
updated it to ;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #12987
Solution
PR Checklist