-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(forge): init a git repo at root during init unless explicitely stated #9695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f7dba2 to
739b81a
Compare
739b81a to
19cd229
Compare
|
I am not sure I like the way git submodules is desired to be used in #3962 (could become beefy and hard to maintain) but rather have different projects / deps with their own foundry.toml file and submodules. @zerosnacks @yash-atreya wdyt? |
|
I'm supportive of this change, I too would expect that when I run Only suggestion I would have is changing the flag name to cc @yash-atreya do you see any issues on how this may interfere with your recent PRs? |
|
@0xvv bump on the previous comment, please flag if you're stuck or need any support from us. |
|
This is orthogonal #3962 but LGTM |
yash-atreya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…ated (foundry-rs#9695) Co-authored-by: grandizzy <[email protected]> Co-authored-by: DaniPopes <[email protected]>
Motivation
Fixes #3962Solution
Force initialization of a git repo at the root of the foundry folder unless there already is one or the flag
--use-parent-gitis present and there is indeed a parent git repo.The
--use-parent-gitflag replicates the current behavior in case some people prefer it.Tested the reproductions steps of the issue after to be sure.
The fix in
forge initleads to the expected behavior forforge install