Skip to content

Conversation

getong
Copy link
Contributor

@getong getong commented Mar 1, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@getong
Copy link
Contributor Author

getong commented Mar 11, 2025

@DaniPopes
This pr all test passed

@getong getong force-pushed the update-axum-0.8 branch 5 times, most recently from 61f50ec to ec8f9a2 Compare March 12, 2025 04:13
@getong
Copy link
Contributor Author

getong commented Mar 12, 2025

How about this pr? It has passed for many time ci test. @DaniPopes

yash-atreya
yash-atreya previously approved these changes Mar 12, 2025
Copy link
Contributor

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes
Copy link
Member

DaniPopes commented Mar 13, 2025

This is fine however it won't remove axum 0.7 due to gcloud-sdk -> tonic -> axum 0.7

@getong
Copy link
Contributor Author

getong commented Apr 13, 2025

wait for alloy-rs/alloy#2317

@jenpaff jenpaff moved this to Ready For Review in Foundry Apr 15, 2025
@DaniPopes
Copy link
Member

Superseded by #10497

@DaniPopes DaniPopes closed this May 19, 2025
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants