Skip to content

Support cheats in meta_tx_v0 #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 29, 2025
Merged

Support cheats in meta_tx_v0 #3649

merged 20 commits into from
Aug 29, 2025

Conversation

MKowalski8
Copy link
Member

@MKowalski8 MKowalski8 commented Aug 18, 2025 •
edited
Loading

Closes #3575

Introduced changes

  • Implement handling ofmeta_tx_v0syscall in snforge, ensuring that cheat codes are properly supported and can be executed during tests.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@MKowalski8 MKowalski8 marked this pull request as ready for review August 19, 2025 22:33
@MKowalski8 MKowalski8 requested a review from a team as a code owner August 19, 2025 22:33
franciszekjob
franciszekjob reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left some nits

@MKowalski8 MKowalski8 requested a review from cptartur August 20, 2025 12:05
ddoktorski
ddoktorski reviewed Aug 20, 2025
View reviewed changes
cptartur
cptartur reviewed Aug 20, 2025
View reviewed changes
@MKowalski8 MKowalski8 changed the title Support cheats in meta_v0_tx Support cheats in meta_tx_v0 Aug 20, 2025
ddoktorski
ddoktorski approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed previously let's confirm with the OZ team whether everything works as expected with this syscall on their end

@MKowalski8 MKowalski8 added this pull request to the merge queue Aug 29, 2025
Merged via the queue into master with commit 548f88a Aug 29, 2025
26 checks passed
@MKowalski8 MKowalski8 deleted the 3575-support-cheats-in-meta_v0_tx branch August 29, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob left review comments

@ddoktorski ddoktorski ddoktorski approved these changes

@cptartur cptartur cptartur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support cheats in meta_v0_tx syscall
4 participants
@MKowalski8 @ddoktorski @cptartur @franciszekjob