-
Notifications
You must be signed in to change notification settings - Fork 235
Feat(sncast): Add utility for calculating a contract's class hash #3651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(sncast): Add utility for calculating a contract's class hash #3651
Conversation
…hash merge master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this command to sncast utils
, it seems like the most reasonable place to have it
Updated! @cptartur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naijauser
Thank you for your contribution! I’ve left a few comments, but overall it looks good :)
Co-authored-by: ddoktorski <[email protected]>
Got it! I've followed the guide now. I've made the changes. Please take another look. Thanks! @cptartur |
@naijauser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left one comment :)
Co-authored-by: Maksymilian Kowalski <[email protected]>
Updated, thank you! @MKowalski8 |
I appreciate your guidance and patience, thank you! @cptartur @ddoktorski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) <!-- Reference any GitHub issues resolved by this PR --> Closes #3584 ## Introduced changes <!-- A brief description of the changes --> ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Nnamdi Aninye <[email protected]> Co-authored-by: ddoktorski <[email protected]> Co-authored-by: Maksymilian Kowalski <[email protected]>
) <!-- Reference any GitHub issues resolved by this PR --> Closes #3584 ## Introduced changes <!-- A brief description of the changes --> ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Nnamdi Aninye <[email protected]> Co-authored-by: ddoktorski <[email protected]> Co-authored-by: Maksymilian Kowalski <[email protected]>
Closes #3584
Introduced changes
Checklist
CHANGELOG.md