Skip to content

Conversation

naijauser
Copy link
Contributor

@naijauser naijauser commented Aug 18, 2025

Closes #3584

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@naijauser naijauser marked this pull request as ready for review August 19, 2025 15:23
@naijauser naijauser requested a review from a team as a code owner August 19, 2025 15:23
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this command to sncast utils, it seems like the most reasonable place to have it

@naijauser
Copy link
Contributor Author

Let's move this command to sncast utils, it seems like the most reasonable place to have it

Updated! @cptartur

Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naijauser
Thank you for your contribution! I’ve left a few comments, but overall it looks good :)

@naijauser
Copy link
Contributor Author

naijauser commented Aug 26, 2025

Please run locally cargo fmt and cargo lint as mentioned in the development guide

Got it! I've followed the guide now.

I've made the changes. Please take another look. Thanks! @cptartur

@ddoktorski
Copy link
Contributor

@naijauser
Please fix failing tests, other than that it looks good to me

Copy link
Member

@MKowalski8 MKowalski8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one comment :)

@naijauser
Copy link
Contributor Author

naijauser commented Aug 26, 2025

Looks good, left one comment :)

Updated, thank you! @MKowalski8

@naijauser
Copy link
Contributor Author

I appreciate your guidance and patience, thank you! @cptartur @ddoktorski

Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddoktorski ddoktorski enabled auto-merge August 27, 2025 13:33
@ddoktorski ddoktorski added this pull request to the merge queue Aug 27, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2025
)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #3584

## Introduced changes

<!-- A brief description of the changes -->


## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Nnamdi Aninye <[email protected]>
Co-authored-by: ddoktorski <[email protected]>
Co-authored-by: Maksymilian Kowalski <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@ddoktorski ddoktorski added this pull request to the merge queue Aug 27, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2025
)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #3584

## Introduced changes

<!-- A brief description of the changes -->


## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Nnamdi Aninye <[email protected]>
Co-authored-by: ddoktorski <[email protected]>
Co-authored-by: Maksymilian Kowalski <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@cptartur cptartur added this pull request to the merge queue Aug 28, 2025
Merged via the queue into foundry-rs:master with commit f800fa8 Aug 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utility to sncast for calculating a contract's class hash
4 participants