-
Notifications
You must be signed in to change notification settings - Fork 239
Support inbuilt devnet accounts #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
This was referenced Sep 29, 2025
Merged
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
franciszekjob
commented
Sep 29, 2025
…arknet-foundry into 3603-2-support-inbuilt-devnet-accounts
…ub.com/foundry-rs/starknet-foundry into 3603-2-support-inbuilt-devnet-accounts
ksew1
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions. Otherwise LGTM 😎
cptartur
reviewed
Oct 3, 2025
cptartur
reviewed
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-request once addressed
…ub.com/foundry-rs/starknet-foundry into 3603-2-support-inbuilt-devnet-accounts
cptartur
approved these changes
Oct 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
<!-- Reference any GitHub issues resolved by this PR --> ## Introduced changes Towards #3603 **Stack**: - #3762 - #3761 - #3760 ⬅ ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: Artur Michalek <[email protected]> Co-authored-by: Artur Michałek <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
<!-- Reference any GitHub issues resolved by this PR --> Closes #3603 **Stack**: - #3762 ⬅ - #3761 - #3760 ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Artur Michalek <[email protected]> Co-authored-by: Artur Michałek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3603
Stack:
DevnetProvider
#3760Checklist
CHANGELOG.md