Handle redeclaration in estimate fee, closes #3253 #3779
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2025
cptartur
force-pushed
the
spr/master/f3897b34
branch
2 times, most recently
from
6a7fed0 to
6806b69
Compare
| accounts_json_path.as_str(), | ||
| "--account", | ||
| "user1", | ||
| "--wait", |
There was a problem hiding this comment.
Why is this added to an existing test?
There was a problem hiding this comment.
Technically the test could fail without it since we run a second declare immediately after the first one. It should be included in the first place.
There was a problem hiding this comment.
Are you sure? I removed --wait from this test, run all delcare tests and they pass so maybe we don't have to add it 🤔 ?
ddoktorski
reviewed
Oct 3, 2025
It was intentional but seems the issue did not link to it, it must be in the description. |
cptartur
force-pushed
the
spr/master/f3897b34
branch
from
6806b69 to
b865c4b
Compare
cptartur
force-pushed
the
spr/master/f3897b34
branch
from
b865c4b to
9a20542
Compare
commit-id:f3897b34
cptartur
force-pushed
the
spr/master/f3897b34
branch
from
9a20542 to
083097f
Compare
ddoktorski
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
wait_for_tx#3782