Skip to content

Handle redeclaration in estimate fee, closes #3253 #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle redeclaration in estimate fee, closes #3253 #3779

wants to merge 1 commit into from

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Oct 3, 2025 •
edited
Loading

This was referenced Oct 3, 2025
Open
Open
Open
Open
@cptartur cptartur marked this pull request as ready for review October 3, 2025 10:53
@cptartur cptartur requested a review from a team as a code owner October 3, 2025 10:53
@cptartur cptartur force-pushed the spr/master/f3897b34 branch 2 times, most recently from 6a7fed0 to 6806b69 Compare October 3, 2025 14:23
franciszekjob
franciszekjob reviewed Oct 3, 2025
View reviewed changes
ddoktorski
ddoktorski reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentionally to include "closes" in the PR title?

@cptartur cptartur linked an issue Oct 6, 2025 that may be closed by this pull request
Improve error message when trying to redeclare contract using sncast declare #3253
Open
@cptartur
Copy link
Member Author

cptartur commented Oct 6, 2025

Was it intentionally to include "closes" in the PR title?

It was intentional but seems the issue did not link to it, it must be in the description.

@cptartur cptartur force-pushed the spr/master/f3897b34 branch from 6806b69 to b865c4b Compare October 6, 2025 11:43
@cptartur cptartur force-pushed the spr/master/f3897b34 branch 2 times, most recently from 9a20542 to 083097f Compare October 6, 2025 14:47
ddoktorski
ddoktorski approved these changes Oct 6, 2025
View reviewed changes
@cptartur cptartur force-pushed the spr/master/f3897b34 branch from 083097f to 63b665a Compare October 7, 2025 12:52
@cptartur cptartur force-pushed the spr/master/f3897b34 branch from 63b665a to a118e3b Compare October 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when trying to redeclare contract using sncast declare
3 participants
@cptartur @ddoktorski @franciszekjob