Skip to content

Resolve #2074 #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: spr/master/adef9534
Choose a base branch
from
Open

Resolve #2074 #3848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/forge/tests/e2e/common/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ pub(crate) fn setup_package_with_file_patterns(

manifest_path.write_str(&scarb_toml.to_string()).unwrap();

// TODO (#2074): do that on .cairo.template files only
replace_node_rpc_url_placeholders(temp.path());

temp
Expand All @@ -187,7 +186,7 @@ fn replace_node_rpc_url_placeholders(dir_path: &Path) {

let path = entry.path();

if path.is_file() {
if path.is_file() && path.extension().is_some_and(|ex| ex == "cairo") {
let content = fs::read_to_string(path).unwrap();

let modified_content = content.replace("{{ NODE_RPC_URL }}", url.as_str());
Expand Down
Loading