Skip to content

Display skipped tests count#4150

Open
franciszekjob wants to merge 20 commits into3548-partitioning-docsfrom
3548-display-skipped-tests-count
Open

Display skipped tests count#4150
franciszekjob wants to merge 20 commits into3548-partitioning-docsfrom
3548-display-skipped-tests-count

Conversation

@franciszekjob
Copy link
Contributor

@franciszekjob franciszekjob commented Feb 4, 2026

Closes #3548

Stack

Introduced changes

Display number of skipped tests due to partitioning

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@franciszekjob franciszekjob changed the title 3548 display skipped tests count Display skipped tests count Feb 4, 2026
@franciszekjob franciszekjob marked this pull request as ready for review February 5, 2026 16:15
@franciszekjob franciszekjob requested a review from a team as a code owner February 5, 2026 16:15
@franciszekjob franciszekjob requested review from DelevoXDG, MKowalski8 and ddoktorski and removed request for a team February 5, 2026 16:15
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm not sure if distinction between filtered out and skipped makes sense to me in this context
  • It's definitely unintuitive in the code that skipped is used for partition, but not for the --skip flag

@franciszekjob
Copy link
Contributor Author

  • I'm not sure if distinction between filtered out and skipped makes sense to me in this context
  • It's definitely unintuitive in the code that skipped is used for partition, but not for the --skip flag

We could add an explicit status "excluded"/"excluded from partition" - should be clearer. Wdyt @ddoktorski ?

@ddoktorski
Copy link
Collaborator

We could add an explicit status "excluded"/"excluded from partition" - should be clearer.

Can we include this information directly in the partition message instead? Something like:

Finished partition run: 1/3, executed 5 out of total 14 test.

@franciszekjob
Copy link
Contributor Author

We could add an explicit status "excluded"/"excluded from partition" - should be clearer.

Can we include this information directly in the partition message instead? Something like:

Finished partition run: 1/3, executed 5 out of total 14 test.

Ok, makes sens. Slight adjustment:

Finished partition run: 1/3, included 5 out of total 14 tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants