Display skipped tests count#4150
Open
franciszekjob wants to merge 20 commits into3548-partitioning-docsfrom
Open
Display skipped tests count#4150franciszekjob wants to merge 20 commits into3548-partitioning-docsfrom
franciszekjob wants to merge 20 commits into3548-partitioning-docsfrom
Conversation
…s/starknet-foundry into 3548-display-skipped-tests-count
This was referenced Feb 4, 2026
…s/starknet-foundry into 3548-display-skipped-tests-count
…s/starknet-foundry into 3548-display-skipped-tests-count
…s/starknet-foundry into 3548-display-skipped-tests-count
…s/starknet-foundry into 3548-display-skipped-tests-count
…/foundry-rs/starknet-foundry into 3548-display-skipped-tests-count
ddoktorski
reviewed
Feb 6, 2026
Collaborator
ddoktorski
left a comment
There was a problem hiding this comment.
- I'm not sure if distinction between
filtered outandskippedmakes sense to me in this context - It's definitely unintuitive in the code that
skippedis used for partition, but not for the--skipflag
Contributor
Author
We could add an explicit status "excluded"/"excluded from partition" - should be clearer. Wdyt @ddoktorski ? |
Collaborator
Can we include this information directly in the partition message instead? Something like: |
Contributor
Author
Ok, makes sens. Slight adjustment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3548
Stack
--partitionflag #4106Introduced changes
Display number of skipped tests due to partitioning
Checklist
CHANGELOG.md