-
Notifications
You must be signed in to change notification settings - Fork 38
List a targets sub-targets/children from acquire using --list-children #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Schamper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also be a nice addition to target-query, just saying 😉.
|
Reworked this PR to use the logic added in target.
By importing these two functions it works the same. Alternatively the Depends on: fox-it/dissect.target#1133 to be merged. |
|
Seeing as fox-it/dissect.target#1133 is now merged, could this be reviewed as well? Pretty much the same code, making the new child support features available from Acquire. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 44.86% 44.90% +0.03%
==========================================
Files 26 26
Lines 3535 3541 +6
==========================================
+ Hits 1586 1590 +4
- Misses 1949 1951 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added a new command line flag "--list-children" that from acquire's main function only returns a human readable list of child targets and exits.
Aims to close #239
Example output on Proxmox:
Acquire can be started with --child <#index> or . For Proxmox the VM name is not obvious as numbers are used. Will create a separate issue to parse these as part of the specific dissect loaders.