Skip to content

Add SharePoint Server logs#257

Merged
Schamper merged 6 commits intofox-it:mainfrom
respondersGY:feature/spse_logs
Jul 30, 2025
Merged

Add SharePoint Server logs#257
Schamper merged 6 commits intofox-it:mainfrom
respondersGY:feature/spse_logs

Conversation

@respondersGY
Copy link
Copy Markdown
Contributor

These logs are very useful to detect ToolShell exploitation events

@respondersGY
Copy link
Copy Markdown
Contributor Author

Example log line.

Timestamp               Process                                         TID     Area                            Category                        EventID Level           Message         Correlation
MM/DD/YYYY HH:MM:ss  w3wp.exe (XXX)                               XXXX  SharePoint Foundation           General                         XXXX    Medium          Application error when access /_layouts/15/spinstall0.aspx, Error=The file '/_layouts/15/spinstall0.aspx' does not exist.  [...]

@respondersGY respondersGY changed the title Add SPSE logs Add SharePoint Server logs Jul 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.93%. Comparing base (884e5fd) to head (8c16bcb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/acquire.py 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   44.80%   44.93%   +0.13%     
==========================================
  Files          26       26              
  Lines        3560     3527      -33     
==========================================
- Hits         1595     1585      -10     
+ Misses       1965     1942      -23     
Flag Coverage Δ
unittests 44.93% <38.46%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@respondersGY
Copy link
Copy Markdown
Contributor Author

Yes I have tested it and it works.

@respondersGY
Copy link
Copy Markdown
Contributor Author

respondersGY commented Jul 30, 2025

The linter fails, should the try-except be removed?

fix: commands[1]> ruff check --fix acquire tests
acquire/acquire.py:874:13: PERF203 `try`-`except` within a loop incurs performance overhead
    |
872 |               try:
873 |                   spec.add(("path", reg_key.value("LogDir").value))
874 | /             except Exception:
875 | |                 pass
    | |____________________^ PERF203
876 |
877 |           return spec
    |

Found 1 error.

@Schamper
Copy link
Copy Markdown
Member

The linter fails, should the try-except be removed?


fix: commands[1]> ruff check --fix acquire tests

acquire/acquire.py:874:13: PERF203 `try`-`except` within a loop incurs performance overhead

    |

872 |               try:

873 |                   spec.add(("path", reg_key.value("LogDir").value))

874 | /             except Exception:

875 | |                 pass

    | |____________________^ PERF203

876 |

877 |           return spec

    |



Found 1 error.

No, you can add a # noqa: PERF203 comment on that line. I'm not sure on the exact syntax but the Ruff VSCode extension can do that automatically as an IntelliSense fix.

@respondersGY respondersGY requested a review from Schamper July 30, 2025 07:40
@Schamper Schamper merged commit 20d2946 into fox-it:main Jul 30, 2025
23 of 25 checks passed
@respondersGY respondersGY deleted the feature/spse_logs branch July 30, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants