Skip collection of large sparse files with tar outputs#262
Closed
joost-j wants to merge 2 commits intofox-it:mainfrom
Closed
Skip collection of large sparse files with tar outputs#262joost-j wants to merge 2 commits intofox-it:mainfrom
joost-j wants to merge 2 commits intofox-it:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 44.93% 44.95% +0.01%
==========================================
Files 26 26
Lines 3527 3530 +3
==========================================
+ Hits 1585 1587 +2
- Misses 1942 1943 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I don't think flat out not collecting evidence is an acceptable solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143 and possible collection of other large (>10GB) sparse files. Adding this to the
TarOutputclass since the Python stdlibtarfile.pydoes not ship with sparse file write support. If specific sparse files need to be collected, they should be treated as special cases just like the UsnJrnl file, as mentioned in ticket #143. This PR at least prevents the creation of huge.tarfiles; as mentioned we encountered tar files of ~500GB because of this.Please let me know if the 10GB threshold is okay, or if we can set it to an even lower value.