This repository was archived by the owner on Nov 20, 2025. It is now read-only.
Update pyproject.toml license settings and minimum python version#49
Merged
Update pyproject.toml license settings and minimum python version#49
Conversation
Contributor
Miauwkeru
commented
Sep 19, 2025
Miauwkeru
commented
- Change the minimum python version to 3.10
- Update deprecated license settings
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 80.35% 80.35%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1133 1133
Misses 277 277
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gustavi
reviewed
Sep 19, 2025
| description = "A Dissect module implementing a parser for Microsofts Extensible Storage Engine Database (ESEDB), used for example in Active Directory, Exchange and Windows Update" | ||
| readme = "README.md" | ||
| requires-python = "~=3.9" | ||
| license.text = "Apache License 2.0" |
Member
There was a problem hiding this comment.
It's an error, there are no plans to change this license. The only acceptable future license changes are other dissect projects to Apache2 😄.
Schamper
suggested changes
Sep 20, 2025
pyproject.toml
Outdated
| requires-python = "~=3.9" | ||
| license.text = "Apache License 2.0" | ||
| requires-python = ">=3.10" | ||
| license = "AGPL-3.0-or-later" |
Miauwkeru
force-pushed
the
update-pyproject-toml-file
branch
from
0f922ef to
f024fb1
Compare
Schamper
previously requested changes
Sep 23, 2025
Member
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
Where are the other pyproject.toml changes?
Schamper
suggested changes
Sep 23, 2025
pyproject.toml
Outdated
|
|
||
| [tool.ruff] | ||
| line-length = 120 | ||
| required-version = ">=0.9.0" |
Miauwkeru
force-pushed
the
update-pyproject-toml-file
branch
from
5af02b2 to
0894bce
Compare
Schamper
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.