refactor: compress Int32Serializer / UInt32Serializer

Author: twiggler

dissect/target/helpers/nfs/nfs3.py

@@ -125,7 +125,7 @@ class MountParams:
 @dataclass
 class MountOK:
     filehandle: FileHandle3
-    authFlavors: list[int]
+    auth_flavors: list[int]
 
 
 @dataclass

dissect/target/helpers/sunrpc/serializer.py

@@ -45,19 +45,17 @@ def deserialize(self, _: io.BytesIO) -> Serializable:
 
 
 class Int32Serializer(Serializer[int], Deserializer[int]):
+    _signed = True
+
     def serialize(self, i: int) -> bytes:
-        return i.to_bytes(length=4, byteorder="big", signed=True)
+        return i.to_bytes(length=4, byteorder="big", signed=self._signed)
 
     def deserialize(self, payload: io.BytesIO) -> int:
-        return int.from_bytes(payload.read(4), byteorder="big", signed=True)
-
+        return int.from_bytes(payload.read(4), byteorder="big", signed=self._signed)
 
-class UInt32Serializer(Serializer[int], Deserializer[int]):
-    def serialize(self, i: int) -> bytes:
-        return i.to_bytes(length=4, byteorder="big", signed=False)
 
-    def deserialize(self, payload: io.BytesIO) -> int:
-        return int.from_bytes(payload.read(4), byteorder="big", signed=False)
+class UInt32Serializer(Int32Serializer):
+    _signed = False
 
 
 class OpaqueVarLengthSerializer(Serializer[bytes], Deserializer[bytes]):

tests/helpers/sunrpc/test_client.py

@@ -87,7 +87,7 @@ def test_mount_call(mock_socket: MagicMock) -> None:
         filehandle=FileHandle3(
             opaque=b"\x01\x00\x07\x00\x02\x00\xec\x02\x00\x00\x00\x00\xb5g\x131&\xf1I\xed\xb8R\rx\\h8\xb4"
         ),
-        authFlavors=[1],
+        auth_flavors=[1],
     )