Skip to content

Add order field to command history records - #1068

Merged
Schamper merged 9 commits into
fox-it:mainfrom
JSCU-CNI:improvement/cmd-history-order
Apr 7, 2025
Merged

Add order field to command history records#1068
Schamper merged 9 commits into
fox-it:mainfrom
JSCU-CNI:improvement/cmd-history-order

Conversation

@JSCU-CNI

Copy link
Copy Markdown
Contributor

This PR adds the order field to command history records. This can be used to reconstruct command history files from records.

Comment thread dissect/target/plugins/apps/shell/powershell.py Outdated
Comment thread dissect/target/plugins/apps/shell/powershell.py
@JSCU-CNI
JSCU-CNI requested a review from Schamper April 2, 2025 12:18
Comment thread dissect/target/plugins/apps/shell/powershell.py
Comment thread dissect/target/plugins/apps/shell/powershell.py Outdated
Comment thread dissect/target/plugins/apps/shell/powershell.py Outdated
Comment thread dissect/target/plugins/apps/shell/powershell.py
Comment thread dissect/target/plugins/os/unix/bsd/citrix/history.py Outdated
Comment thread dissect/target/plugins/os/unix/bsd/citrix/history.py Outdated
Comment thread dissect/target/plugins/os/unix/bsd/citrix/history.py Outdated
Comment thread dissect/target/plugins/os/unix/bsd/citrix/history.py Outdated
Comment thread dissect/target/plugins/os/unix/history.py
Comment thread dissect/target/plugins/os/unix/history.py Outdated
@JSCU-CNI
JSCU-CNI requested a review from Schamper April 2, 2025 14:09
Comment thread dissect/target/plugins/os/unix/bsd/citrix/history.py
@JSCU-CNI
JSCU-CNI requested a review from Schamper April 7, 2025 12:28
@codecov

codecov Bot commented Apr 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (623b4bb) to head (4cb4dc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage   79.26%   79.26%           
=======================================
  Files         346      346           
  Lines       30679    30689   +10     
=======================================
+ Hits        24318    24327    +9     
- Misses       6361     6362    +1     
Flag Coverage Δ
unittests 79.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper
Schamper merged commit b811c4a into fox-it:main Apr 7, 2025
@JSCU-CNI
JSCU-CNI deleted the improvement/cmd-history-order branch April 7, 2025 13:51
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request May 26, 2026
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request Jun 4, 2026
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request Jun 5, 2026
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants