Skip to content

Improve NGINX plugin#1073

Merged
Schamper merged 13 commits intofox-it:mainfrom
JSCU-CNI:feature/rewrite-nginx-plugin
Apr 7, 2025
Merged

Improve NGINX plugin#1073
Schamper merged 13 commits intofox-it:mainfrom
JSCU-CNI:feature/rewrite-nginx-plugin

Conversation

@JSCU-CNI
Copy link
Copy Markdown
Contributor

@JSCU-CNI JSCU-CNI commented Mar 19, 2025

This PR adds several improvements to the NGINX plugin:

  1. Add error.log parsing
  2. Server hosts parsing
  3. JSON access.log parsing
  4. Improved server configuration (.conf) parsing

JSCU-CNI and others added 3 commits March 24, 2025 12:40
JSCU-CNI and others added 2 commits April 2, 2025 10:25
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@JSCU-CNI JSCU-CNI requested a review from Schamper April 2, 2025 08:25
@JSCU-CNI JSCU-CNI changed the title Improve Nginx plugin Improve NGINX plugin Apr 2, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 79.02098% with 30 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (b811c4a) to head (1646c9a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/apps/webserver/nginx.py 79.02% 30 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1073    +/-   ##
========================================
  Coverage   79.26%   79.27%            
========================================
  Files         346      346            
  Lines       30689    30793   +104     
========================================
+ Hits        24327    24411    +84     
- Misses       6362     6382    +20     
Flag Coverage Δ
unittests 79.27% <79.02%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 13:01
Copy link
Copy Markdown
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style change

JSCU-CNI and others added 2 commits April 7, 2025 15:38
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@Schamper Schamper merged commit 764c133 into fox-it:main Apr 7, 2025
19 of 23 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/rewrite-nginx-plugin branch April 7, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants