Conversation
Schamper
left a comment
There was a problem hiding this comment.
Can you add an example in the docstring for what this actually checks/calls out? It's a bit hard to determine from just the test.
CodSpeed Performance ReportMerging #1192 will not alter performanceComparing Summary
|
Added in 2439d34. Please let me know if this makes more sense now. |
|
Fixed in 37adb05. |
|
The changes in #1189 will make the tests in this PR pass, would you like to merge those changes in this PR or to merge that PR first? |
I know, I have some pending comments on that. Just marking this as approved already, but waiting to merge of course. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 366 366
Lines 33476 33476
=======================================
Hits 26237 26237
Misses 7239 7239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds tests to prevent duplicate field names with incompatible field types as identified and fixed in #1189, #990 and #982.