Add Windows Search Index plugin#1254
Conversation
|
@JSCU-CNI thanks for this contribution! @DevJoost and I had been working on this plugin before and we have some code that might be useful. DevJoost's original implementation: searchindex.py My additions: searchindex.py My (very WIP) attempt to merge part of your and mine implementation: search.py These changes rely on some additions to dissect.sql: sqlite3.py As of writing I have made a POC for the following: Things that DevJoost has made and could be added: While comparing our implementations I was wondering about two implementation differences: would it be useful to add more fields to the records, like the SDID or owner? What is the advantage of not reading the WAL? As I understand it, this could be used to read the latest changes to the index and potentially track changes over time. Could you elaborate on these decisions? |
How do you propose we continue? Do you see any fundamental implementation changes purely related to the searchindex plugin? You could fork our fork and open a PR on this branch so we can properly compare your changes against this feature branch.
This seems useful - along with parsing the write ahead log file, but seems somewhat unrelated to this PR. Perhaps we can modify
Parsing SDID or owner certainly seems useful, but out of scope from our point of view for now due to time constrains. Not parsing the WAL is not a deliberate decision, as elaborated above. |
|
I think I will continue working on |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 80.90% 80.92% +0.02%
==========================================
Files 376 377 +1
Lines 33412 33531 +119
==========================================
+ Hits 27031 27134 +103
- Misses 6381 6397 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1254 will not alter performanceComparing Summary
|
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Implements #283. Depends on two bugfixes in fox-it/dissect.sql#37 and fox-it/dissect.esedb#48.