-
Notifications
You must be signed in to change notification settings - Fork 75
Add support for unarchived Acquire directories #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello @qmadev, the change you submitted will not fix the underlying issue that you are experiencing. One reason would be that this change will make it path specific. Where a change inside of the path name will result in dissect not being able to find a specific file. E.g. not being able to find The proper fix for this issue is handling the case sensitivity inside the DirLoader. Where it should "merge" the contents of folders that have the same name if case sensitivity is false (that it is case insensitive). E.g. merging |
|
I'm confused. Is this not handling the case sensitivity in the dir loader? |
No, the change makes the filesystem case sensitive, so a file named What one would expect from targeting the resulting acquire directory is that you would have similar behaviour as the tar loader. So using However, the current fix doesn't do this and you get part of the result. For example, the directory From some debugging, I feel it might be going wrong inside the
|
|
Thanks! Starting to understand it a little bit better now. Will look into this further soon. |
|
I thought about it. Having trouble with merging the paths. Any suggestions? |
|
@Miauwkeru any suggestions on how to "merge" directories? |
|
Hi @qmadev, I was unavailable for a bit. I have been looking into this issue and i think it might be a bit deeper than expected. One solution I can think of at the top of my head is adding layers to the root filesystem if it finds more than one entry with the "same" name. But I am not yet sure this is the best way to tackle this issue. I think it requires a bit more research. I will try to get it to be discussed soon |
Doing this does not work:
This PR adds a fix for that. The reason seems to be that Acquire still has both a "windows" and "Windows" folder.