-
Notifications
You must be signed in to change notification settings - Fork 7
Update devcontainer configuration #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 27 27
Lines 1881 1881
=====================================
Misses 1881 1881
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #108 will not alter performanceComparing Summary
Footnotes
|
.devcontainer/devcontainer.json
Outdated
| "name": "Dissect", | ||
| "image": "ghcr.io/fox-it/dissect-devcontainer", | ||
| "postCreateCommand": "pip3 install --user --editable . --config-settings editable_mode=compat" | ||
| "postCreateCommand": "pip3 install --user --editable . --config-settings editable_mode=compat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't create a .venv directory here and install it in there? Mostly because we specify to use the .venv directory here: https://github.com/fox-it/dissect-devcontainer-templates/blob/4d8e655cfbad2fcbb38326e144e408853440f068/.devcontainer/devcontainer.json#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh forgot to update it here.
15ee748 to
5f879e0
Compare
ad8fcff to
6862f39
Compare
Add Rust configuration