Skip to content

Conversation

@Schamper
Copy link
Member

Add Rust configuration

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (2c2d96e) to head (6862f39).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #108   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         27      27           
  Lines       1881    1881           
=====================================
  Misses      1881    1881           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025

CodSpeed Performance Report

Merging #108 will not alter performance

Comparing update-devcontainer (6862f39) with main (2c2d96e)

Summary

✅ 26 untouched
⏩ 10 skipped1

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

"name": "Dissect",
"image": "ghcr.io/fox-it/dissect-devcontainer",
"postCreateCommand": "pip3 install --user --editable . --config-settings editable_mode=compat"
"postCreateCommand": "pip3 install --user --editable . --config-settings editable_mode=compat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't create a .venv directory here and install it in there? Mostly because we specify to use the .venv directory here: https://github.com/fox-it/dissect-devcontainer-templates/blob/4d8e655cfbad2fcbb38326e144e408853440f068/.devcontainer/devcontainer.json#L29

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh forgot to update it here.

@Schamper Schamper force-pushed the update-devcontainer branch from 15ee748 to 5f879e0 Compare October 29, 2025 12:17
@Schamper Schamper requested a review from Miauwkeru October 29, 2025 12:18
@Schamper Schamper force-pushed the update-devcontainer branch from ad8fcff to 6862f39 Compare October 29, 2025 13:16
@Schamper Schamper merged commit f58bb31 into main Oct 29, 2025
33 checks passed
@Schamper Schamper deleted the update-devcontainer branch October 29, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants