Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 87.90% 0.00% -87.91%
==========================================
Files 21 22 +1
Lines 1356 1362 +6
==========================================
- Hits 1192 0 -1192
- Misses 164 1362 +1198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #56 will not alter performanceComparing Summary
|
07e3c6c to
fdef9a8
Compare
twiggler
requested changes
Jun 12, 2025
twiggler
previously approved these changes
Jun 16, 2025
Miauwkeru
reviewed
Jun 25, 2025
Miauwkeru
reviewed
Jun 25, 2025
Miauwkeru
reviewed
Jun 25, 2025
Contributor
Miauwkeru
left a comment
There was a problem hiding this comment.
once the workflow gets merged in, LGTM
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Miauwkeru
approved these changes
Jun 25, 2025
Merged
Schamper
added a commit
to fox-it/dissect
that referenced
this pull request
Jun 26, 2025
They no longer exist and are no longer necessary since fox-it/dissect.util#56
This was referenced Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental branch for playing around with Rust powered modules. With this POC I initially set out to replace the dependencies on the
lz4andpython-lzoPython dependencies, and replacing them with a Rust powered extension.The concept here is that we will use
setuptools-rustto build wheels that contain the Rust compiled extension, but we will not change the build system inpyproject.toml. This is to ensure that we will never compile when installing a "source wheel". Instead, we will continue to usetox -e buildto build Python-only wheels, and in parallel build Rust wheels withsetuptools-rust. The theory here being that on apip install, the following will happen:Play along at home:
Depends on fox-it/dissect-workflow-templates#44