Skip to content

Improve benchmarks and add more#77

Merged
Schamper merged 1 commit intomainfrom
more-benchies
May 20, 2025
Merged

Improve benchmarks and add more#77
Schamper merged 1 commit intomainfrom
more-benchies

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented May 1, 2025

No description provided.

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (3857d2a) to head (ef255c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          20       20           
  Lines        1292     1292           
=======================================
  Hits         1129     1129           
  Misses        163      163           
Flag Coverage Δ
unittests 87.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented May 1, 2025

CodSpeed Performance Report

Merging #77 will degrade performances by 10.33%

Comparing more-benchies (ef255c7) with main (3857d2a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 3 untouched benchmarks
🆕 6 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_benchmark_lznt1_decompress N/A 106.6 µs N/A
🆕 test_benchmark_lzxpress_decompress N/A 133.7 µs N/A
🆕 test_benchmark_lzxpress_huffman_decompress N/A 2.5 ms N/A
🆕 test_benchmark_sevenbit_compress N/A 61.1 µs N/A
🆕 test_benchmark_sevenbit_decompress N/A 57.6 µs N/A
🆕 test_benchmark_sevenbit_decompress_wide N/A 61 µs N/A
test_crc32c_benchmark 39.2 µs 33.7 µs +16.57%
test_aligned_stream_read_fixed_size_benchmark 43.9 µs 48.9 µs -10.33%

@Horofic Horofic requested review from Horofic and Copilot May 20, 2025 10:08
@Horofic Horofic self-assigned this May 20, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds and refines benchmarking across the test suite, updates linting tooling, and centralizes benchmark marker handling.

  • Update default tox testenv to run only benchmark-marked tests and bump ruff version
  • Inject __future__ annotations and TYPE_CHECKING imports in tests, remove repetitive skip logic
  • Add conftest.py to register/skip benchmark marker when plugin is missing

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

File Description
tox.ini Change default pytest command to only run benchmark tests; bump ruff to 0.11.7
tests/*.py Add from __future__ import annotations and TYPE_CHECKING imports; replace skipif with @pytest.mark.benchmark
tests/conftest.py New file to define and skip on missing benchmark marker
pyproject.toml Bump tool.ruff.required-version to >=0.11.0
Comments suppressed due to low confidence (1)

tox.ini:32

  • The default testenv now filters only benchmark tests and omits regular unit tests; consider running benchmarks in a separate env or removing -m benchmark to avoid skipping non-benchmark tests.
pytest --basetemp="{envtmpdir}" -m benchmark {posargs:--color=yes -v tests}

@Schamper Schamper merged commit 2037847 into main May 20, 2025
24 of 25 checks passed
@Schamper Schamper deleted the more-benchies branch May 20, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants