Skip to content

Conversation

@yunzheng
Copy link
Member

@yunzheng yunzheng commented Dec 1, 2025

fixes #197
supersedes #196

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.27%. Comparing base (b0cb20a) to head (3c9940a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flow/record/base.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   83.42%   83.27%   -0.15%     
==========================================
  Files          35       35              
  Lines        3699     3696       -3     
==========================================
- Hits         3086     3078       -8     
- Misses        613      618       +5     
Flag Coverage Δ
unittests 83.27% <85.71%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates from the third-party zstandard library to the stdlib compression.zstd (Python 3.14+) or its backport backports.zstd (Python <3.14). The changes simplify the API calls and remove the PyPy restriction for zstd compression support.

  • Replaces zstandard with conditional import of compression.zstd (Python ≥3.14) or backports.zstd (Python <3.14)
  • Updates zstd API usage from separate compressor/decompressor contexts to unified ZstdFile interface
  • Removes PyPy restriction for zstd compression support

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updates dependency from zstandard to backports.zstd with Python version constraint
flow/record/base.py Implements conditional import logic and updates API usage from context-based compression to ZstdFile
tests/record/test_adapter.py Updates skip message and removes PyPy restriction test skip

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yunzheng yunzheng merged commit f3a1c5f into main Dec 4, 2025
22 of 23 checks passed
@yunzheng yunzheng deleted the compression-zstd branch December 4, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use backports.zstd for zstandard compression

3 participants