Skip to content

Bugfix/fix template issue #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesFreeman merged 13 commits into from
Dec 2, 2025
Merged

Bugfix/fix template issue #139

Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a8bea80
fix example issues
JamesFreeman Dec 2, 2025
f3923ce
fix
JamesFreeman Dec 2, 2025
4fd6cc0
fix
JamesFreeman Dec 2, 2025
909bcaa
fix
JamesFreeman Dec 2, 2025
fcd53b5
fix
JamesFreeman Dec 2, 2025
f2918d9
fix
JamesFreeman Dec 2, 2025
0ed434c
wip
JamesFreeman Dec 2, 2025
91516fd
doc
JamesFreeman Dec 2, 2025
6a6d54a
doc
JamesFreeman Dec 2, 2025
99f6d20
update
JamesFreeman Dec 2, 2025
5a3e464
fix
JamesFreeman Dec 2, 2025
f27647b
wip
JamesFreeman Dec 2, 2025
97a31d7
Update docs/examples.md
JamesFreeman Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions docs/examples.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
---
render_with_liquid: false
---

*app\Http\Controllers\XeroController.php*

```php
Expand Down Expand Up @@ -45,10 +49,11 @@ class XeroController extends Controller

*resources\views\xero.blade.php*

```
@extends('_layouts.main')

@section('content')
{% raw %}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The front matter render_with_liquid: false at the top of the file should already prevent Liquid from processing the contents. Therefore, wrapping this block in {% raw %} and {% endraw %} (on line 77) is likely redundant. It's cleaner to rely on the front matter for the entire file. I recommend removing the {% raw %} and {% endraw %} tags.

```bladehtml
@extends('_layouts.main')

@section('content')
@if($error)
<h1>Your connection to Xero failed</h1>
<p>{{ $error }}</p>
Expand All @@ -67,9 +72,9 @@ class XeroController extends Controller
Connect to Xero
</a>
@endif
@endsection
@endsection
```

{% endraw %}
*routes/web.php*

```php
Expand Down
Loading