Conversation
Disable the `thelper` linter that checks that test helpers call `t.Helper()` as the first thing as switching to `matryer/is` means we will use `is.Helper()` instead, and the linter does not know about that.
juliaogris
approved these changes
Dec 15, 2025
Member
juliaogris
left a comment
juliaogris
left a comment
There was a problem hiding this comment.
Looks great! unbelievable how much easier this is for me to parse. I will use is form here onwards too.
In last commit: strechr/testify → should be stretchr/testify (missing t)
Convert all the tests from using `stretchr/testify` to `matryer/is`. `is` is a much smaller package with fewer dependencies. Most of the additional functionality of testify can be replaced with direct Go code or the `google/go-cmp` package (which we do not need here yet). Fix the comment on `IsAncestor()` which had some bits backwards. Also fix the test comment for `IsAncestor()` which had the same backwards.
Member
Author
Fixed. PTAL 🍪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all the tests from using
stretchr/testifytomatryer/is.isis a much smaller package with fewer dependencies. Most of the
additional functionality of testify can be replaced with direct Go code
or the
google/go-cmppackage (which we do not need here yet).Fix the comment on
IsAncestor()which had some bits backwards. Alsofix the test comment for
IsAncestor()which had the same backwards.Disable the
thelperlinter as it does not know aboutis.Helper().Issue: #7