Skip to content

Conversation

@MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented Jul 7, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

AS IS

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed cargo x (or cargo x --fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #1059
apache/opendal#6366

@MrCroxx MrCroxx added this to the v0.18 milestone Jul 7, 2025
@MrCroxx MrCroxx self-assigned this Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer/src/hybrid/error.rs 62.85% 13 Missing ⚠️
foyer/src/hybrid/cache.rs 66.66% 5 Missing ⚠️
foyer-memory/src/error.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/cache.rs 77.10% <100.00%> (ø)
foyer-memory/src/raw.rs 90.74% <100.00%> (ø)
foyer/src/hybrid/builder.rs 92.59% <100.00%> (ø)
foyer-memory/src/error.rs 0.00% <0.00%> (ø)
foyer/src/hybrid/cache.rs 84.68% <66.66%> (+0.26%) ⬆️
foyer/src/hybrid/error.rs 62.85% <62.85%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCroxx MrCroxx merged commit 9878597 into main Jul 8, 2025
44 checks passed
@MrCroxx MrCroxx deleted the xx/expose-error branch July 8, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

refactor: expose internal error instead of using anyhow for hybrid cache and fetch API

2 participants