Skip to content

Rujira secured withdraw#61

Merged
anakinzhed merged 2 commits intomainfrom
rujira-secured-withdraw
Jun 3, 2025
Merged

Rujira secured withdraw#61
anakinzhed merged 2 commits intomainfrom
rujira-secured-withdraw

Conversation

@snoyberg
Copy link
Member

@snoyberg snoyberg commented Jun 3, 2025

I was doing some experimentation on stagenet with secured assets, and wanted to be able to withdraw to an external chain. This implements a working flow based on some manual testing.

@snoyberg snoyberg requested review from anakinzhed and Copilot June 3, 2025 14:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a secured-withdraw flow for Rujira assets by defining new Protobuf message types, a MsgDeposit wrapper for withdrawals, and wiring it into the CLI and transaction builder.

  • Define internal Protobuf messages (MsgDepositInner, RujiraCoin, RujiraAsset) and public MsgDeposit struct
  • Implement From<MsgDeposit>TxMessage encoding logic with description and memo
  • Add withdraw subcommand in cosmos-bin and display the memo/messages in the chain inspect command

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/cosmos/src/rujira.rs New Rujira Protobuf types, MsgDeposit struct, and conversion
packages/cosmos/src/lib.rs Exported the rujira module
packages/cosmos-bin/src/rujira.rs Added Withdraw CLI subcommand for secured asset withdrawal
packages/cosmos-bin/src/chain.rs Extended transaction inspection to print memo and message details
Comments suppressed due to low confidence (2)

packages/cosmos/src/rujira.rs:256

  • There's no unit test covering the MsgDepositTxMessage conversion; consider adding tests to verify the encoding, description, and memo format.
impl From<MsgDeposit> for TxMessage {

packages/cosmos/src/rujira.rs:243

  • Public struct MsgDeposit lacks doc comments on its fields; consider adding /// comments for each field to document their purpose.
pub struct MsgDeposit {

@anakinzhed anakinzhed merged commit 547a58c into main Jun 3, 2025
1 check passed
@anakinzhed anakinzhed deleted the rujira-secured-withdraw branch June 3, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants