Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a secured-withdraw flow for Rujira assets by defining new Protobuf message types, a MsgDeposit wrapper for withdrawals, and wiring it into the CLI and transaction builder.
- Define internal Protobuf messages (
MsgDepositInner,RujiraCoin,RujiraAsset) and publicMsgDepositstruct - Implement
From<MsgDeposit>→TxMessageencoding logic with description and memo - Add
withdrawsubcommand incosmos-binand display the memo/messages in thechaininspect command
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/cosmos/src/rujira.rs | New Rujira Protobuf types, MsgDeposit struct, and conversion |
| packages/cosmos/src/lib.rs | Exported the rujira module |
| packages/cosmos-bin/src/rujira.rs | Added Withdraw CLI subcommand for secured asset withdrawal |
| packages/cosmos-bin/src/chain.rs | Extended transaction inspection to print memo and message details |
Comments suppressed due to low confidence (2)
packages/cosmos/src/rujira.rs:256
- There's no unit test covering the
MsgDeposit→TxMessageconversion; consider adding tests to verify the encoding, description, and memo format.
impl From<MsgDeposit> for TxMessage {
packages/cosmos/src/rujira.rs:243
- Public struct
MsgDepositlacks doc comments on its fields; consider adding///comments for each field to document their purpose.
pub struct MsgDeposit {
anakinzhed
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some experimentation on stagenet with secured assets, and wanted to be able to withdraw to an external chain. This implements a working flow based on some manual testing.