PERP-4568 | Refactor CosmosInterceptor and parse COSMOS_GRPC#65
Merged
anakinzhed merged 4 commits intomainfrom Jul 10, 2025
Merged
PERP-4568 | Refactor CosmosInterceptor and parse COSMOS_GRPC#65anakinzhed merged 4 commits intomainfrom
anakinzhed merged 4 commits intomainfrom
Conversation
snoyberg
reviewed
Jul 9, 2025
snoyberg
requested changes
Jul 10, 2025
snoyberg
approved these changes
Jul 10, 2025
packages/cosmos/src/client/node.rs
Outdated
| let grpc_channel = grpc_endpoint.connect_lazy(); | ||
|
|
||
| let referer_header = self.referer_header().map(|x| x.to_owned()); | ||
| if !headers.iter().any(|(k, _)| k.as_str() == "referer") { |
Member
There was a problem hiding this comment.
NIT: It would be better to reverse these conditionals: first check if the referer_header() is Some since it's the cheaper test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.