Skip to content

Conversation

@taimoorzaeem
Copy link
Collaborator

@taimoorzaeem taimoorzaeem commented Sep 28, 2025

The HostIPv6Only host preference was allowing IPv4 connections. This commits fixes this by setting a IPv6Only socket option which was required for it to work for IPv6 only connections.

I have tested this locally and this is working as expected. Related #78.

@taimoorzaeem taimoorzaeem changed the title Fix HostIPv6Only host preference also allow IPv4 connections Fix !6 host preference incorrectly allows IPv4 connections Sep 28, 2025
@taimoorzaeem
Copy link
Collaborator Author

Hi @snoyberg!

Would it be possible for you to review this when you have time? I believe this shouldn't take much time to review because it's a pretty small change. Thanks in advance!

I can bump the version and add changelog as well, just let me know if that's okay.

@snoyberg
Copy link
Member

Hi @taimoorzaeem, for the most part I'm not actively maintaining my Haskell projects and I'm looking for comaintainers to step in for regular maintenance. I think this change should be fine though. Yes, a version bump and changelog entry addition would be great, and then I can merge and release.

@taimoorzaeem
Copy link
Collaborator Author

I think this change should be fine though. Yes, a version bump and changelog entry addition would be great, and then I can merge and release.

Done. Thank you in advance.

Hi @taimoorzaeem, for the most part I'm not actively maintaining my Haskell projects and I'm looking for comaintainers to step in for regular maintenance.

@snoyberg I work on the https://github.com/PostgREST/postgrest project and I would be more than happy to be a co-maintainer, especially for the packages that are dependencies of PostgREST, as they often require upstream maintenance.

@snoyberg
Copy link
Member

Awesome, sounds great! I've added you as a maintainer on this repo. If you give me your Hackage username, I can add you there. And if there are other packages you'd be interested in maintaining, just let me know. I very much appreciate it :)

@taimoorzaeem
Copy link
Collaborator Author

Awesome, sounds great! I've added you as a maintainer on this repo. If you give me your Hackage username, I can add you there. And if there are other packages you'd be interested in maintaining, just let me know. I very much appreciate it :)

Many thanks @snoyberg! My hackage username is taimoorzaeem.

@taimoorzaeem taimoorzaeem marked this pull request as draft October 23, 2025 13:16
@snoyberg
Copy link
Member

Great, added!

image

@taimoorzaeem taimoorzaeem marked this pull request as ready for review October 24, 2025 10:01
The `HostIPv6Only` host preference was allowing IPv4 connections.
This commits fixes this by setting a IPv6Only socket option which
was required for it to work for IPv6 only connections.

Signed-off-by: Taimoor Zaeem <[email protected]>
@taimoorzaeem taimoorzaeem merged commit 2cb9288 into fpco:master Oct 24, 2025
87 of 88 checks passed
@taimoorzaeem taimoorzaeem deleted the fix/ipv6-only-host-preference branch October 24, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants