This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Open
Conversation
Contributor
Author
|
The main motivation for this module is the fact that TF 0.12 doesn't allow for_each to be used with modules (though the argument is already reserved for future versions). Because of that |
ketzacoatl
suggested changes
Dec 5, 2019
Contributor
ketzacoatl
left a comment
There was a problem hiding this comment.
Minor updates:
- add example to the doc
- update
tests/main.tfto include this module with empty params
| @@ -0,0 +1,3 @@ | |||
| ## Multiple Port Security Group Rule | |||
|
|
|||
| Create an `aws_security_group_rule` to allow ingress on some ports. | |||
Contributor
There was a problem hiding this comment.
Please add an example of how you intend the module to be used.
| type = set(string) | ||
| default = [] | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Separate the above into a variables.tf
| protocol = "udp" | ||
| cidr_blocks = var.cidr_blocks | ||
| security_group_id = var.security_group_id | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Multip-port security group module
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modulesthis would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.