This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Conversation
Member
Author
|
@ketzacoatl Proof that it actually works is documented on the README (with snapshots): https://github.com/fpco/terraform-aws-foundation/blob/6fd06a686c6f17f27d3374e3207523f499ce14fe/examples/ad-asg/README.md |
ketzacoatl
approved these changes
Feb 27, 2020
| # Active Directory with seamless Windows EC2 join (from ASG) | ||
|
|
||
| The terraform code is built on top of | ||
| [vpc-scenario1](https://docs.aws.amazon.com/vpc/latest/userguide/VPC_Scenario1.html) |
Contributor
There was a problem hiding this comment.
Would VPC Scenario 2 work here too?
Member
Author
There was a problem hiding this comment.
@ketzacoatl It will work, but it will require some slight modifications.
| [ASG](https://docs.aws.amazon.com/autoscaling/ec2/userguide/AutoScalingGroup.html) | ||
| seamlessly joins an Active directory when it gets newly spawned. The | ||
| only difference between this example and the [ad-ec2](../ad-ec2) is | ||
| that this example uses ASG. |
Contributor
There was a problem hiding this comment.
Should we include all of the EC2/ASG/windows/linux variants in one single example? and do the "across VPCs" in a second example?
Member
Author
There was a problem hiding this comment.
I feel having different example more clearly explains the differences. But I don't have strong opinion on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modulesthis would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.