getMonotonicTime should return the number of seconds rather than nanoseconds on osx#127
Merged
jkeuhlen merged 1 commit intofpco:masterfrom Sep 4, 2025
Merged
Conversation
snoyberg
approved these changes
Sep 3, 2025
snoyberg
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally described the problem I was seeing via
stack build --debugover here: commercialhaskell/rio-prettyprint#26The tldr; is stack's debug output was off by a factor of 10^9 in reporting how long things took to run.
Sorting through the commit history I found #91 which solved a build issue, but I think introduced this regression.
via https://www.manpagez.com/man/3/clock_gettime_nsec_np/, clock_gettime_nsec_np returns the number of nanoseconds:
#91 references this similar work done in the criterion PR which did have the
/ 1e9: haskell/criterion@607b18c#diff-2a2fbceda772ad663c4dab2a9d6d8350662f5c4d3012819e8ec5d45574330318R8