[PerlCritic] disable locally some rules

Author: fperrad

perl/gherkin-perl.razor

@@ -35,12 +35,14 @@ use warnings;
 
 use base 'Gherkin::ParserBase';
 
+## no critic (ProhibitMagicNumbers)
 my %states_to_match_names = (
     @foreach(var state in Model.States.Values.Where(s => !s.IsEndState)) //..
     {
 @:    @state.Id => 'match_token_at_@(state.Id)',
     }
 );
+## use critic
 
 sub parse {
     my ( $self, $token_scanner, $uri ) = @@_;
@@ -94,6 +96,7 @@ sub _construct_parser_error {
     return $error_class->new( $token, @@args );
 }
 
+## no critic (ProhibitExcessComplexity, ProhibitMagicNumbers, ProhibitPostfixControls)
 @foreach(var state in Model.States.Values.Where(s => !s.IsEndState)) //..
 {<text>
 # @Raw(state.Comment)
@@ -126,6 +129,7 @@ sub match_token_at_@(state.Id) {
 </text>
 }
 
+## use critic
 @foreach(var lookAheadHint in Model.RuleSet.LookAheadHints)
 {
 <text>

perl/lib/Gherkin.pm

@@ -39,8 +39,10 @@ sub from_paths {
         # accommodates the errors and simply continues, allowing us to
         # recode back to octets and then to the encoding indicated in the
         # header using the "# encoding: ..." header.
+        ## no critic (RequireEncodingWithUTF8Layer)
         open my $fh, '<:utf8', $path
             or die "Unable to open gherkin document $path: $!";
+        ## use critic
 
         # local $/ = undef; --> unset 'end-of-line' marker: slurp entire file
         # use the 'do' block to scope this binding to smallest possible scope

perl/lib/Gherkin/AstBuilder.pm

@@ -165,6 +165,7 @@ sub next_id {
     return $self->{'id_generator'}->();
 }
 
+## no critic (ProhibitExcessComplexity, ProhibitCascadingIfElse)
 sub transform_node {
     my ( $self, $node ) = @_;
 
@@ -358,5 +359,6 @@ sub transform_node {
         return $node;
     }
 }
+## use critic
 
 1;

perl/lib/Gherkin/Dialect.pm

@@ -23,8 +23,10 @@ sub new {
             close $fh;
             $options->{'dictionary'} = Cpanel::JSON::XS::decode_json($input);
         } else {
+            ## no critic (ProhibitPackageVars)
             require Gherkin::Generated::Languages;
             $options->{'dictionary'} = $Gherkin::Generated::Languages::data;
+            ## use critic
         }
     }
 

perl/lib/Gherkin/Exceptions.pm

@@ -1,3 +1,5 @@
+## no critic (ProhibitMultiplePackages, RequireExplicitPackage)
+
 use strict;
 use warnings;
 

perl/lib/Gherkin/Generated/Parser.pm

@@ -6,6 +6,7 @@ use warnings;
 
 use base 'Gherkin::ParserBase';
 
+## no critic (ProhibitMagicNumbers)
 my %states_to_match_names = (
     0 => 'match_token_at_0',
     1 => 'match_token_at_1',
@@ -50,6 +51,7 @@ my %states_to_match_names = (
     41 => 'match_token_at_41',
     42 => 'match_token_at_42',
 );
+## use critic
 
 sub parse {
     my ( $self, $token_scanner, $uri ) = @_;
@@ -103,6 +105,7 @@ sub _construct_parser_error {
     return $error_class->new( $token, @args );
 }
 
+## no critic (ProhibitExcessComplexity, ProhibitMagicNumbers, ProhibitPostfixControls)
 
 # Start
 sub match_token_at_0 {
@@ -3879,6 +3882,7 @@ sub match_token_at_42 {
     return 42;
 }
 
+## use critic
 
 sub lookahead_0 {
     my ($self, $context, $current_token) = @_;

perl/lib/Gherkin/ParserBase.pm

@@ -43,6 +43,8 @@ sub add_error {
     return;
 }
 
+## no critic (Subroutines::ProhibitUnusedPrivateSubroutines)
+
 sub _start_rule {
     my ( $self, $context, $ruleType ) = @_;
 

perl/lib/Gherkin/TokenScanner.pm

@@ -16,6 +16,7 @@ sub new {
 
     # Perl convention is that a string reference is the string itself, but that
     # a straight string is a path
+    ## no critic (RequireBriefOpen)
     my $fh;
     if ( ref $path_or_str eq 'SCALAR' ) {
         my $bytes = Encode::encode('UTF-8', ${ $path_or_str });
@@ -25,6 +26,7 @@ sub new {
           || croak "Can't open [$path_or_str] for reading";
         $fh->binmode(':utf8');
     }
+    ## use critic
 
     return bless { fh => $fh, line_number => 0 }, $class;
 }