Skip to content

Conversation

@aardvarkk
Copy link

I ran into a problem building react-native-maps-osmdroid due to the an issue that was fixed in react-native-maps with this PR. I thought I'd do a merge commit that brought in the latest changes and fixes. I'm not sure if there are tests suites or anything that need to be run, but this was a first cut at a merge commit to reconcile the two and bring in any new changes.

cristeahub and others added 30 commits October 3, 2019 19:35
This change makes sure that we safely check to see if supportLibVersion
is set before we try to use this.
* [iOS] Expose isAccessibilityElement as a prop

* Set default isAccessibilityElement to NO, update readme
Line break types for "paddingAdjustmentBehavior" to decrease type-column width which increases Note column width. It was hard to browse props when Prop and Note columns were not visible at the same time (due to horisontal scroll in table and hidden overflow).
* add marker property isAlwaysSelected on iOS

* updated naming of feature to isPreselected to better reflect functionality

* updated Marker component docs for isPreselected prop
Clarify that the developer has a choice between using npm and Yarn when installing the package
cristian21taz and others added 30 commits June 11, 2020 07:47
Fixed a typeo where the docs were referencing a version (10.0.1) which doesn't exist anymore.
* Fix for build fail react-native-maps#3565

* Linting

* Trying to fix travis

Co-authored-by: Dan Tamas <[email protected]>
* fix: Xcode 12 compatibility

* Fix for build fail react-native-maps#3565 (react-native-maps#3566)

* Fix for build fail react-native-maps#3565

* Linting

* Trying to fix travis

Co-authored-by: Dan Tamas <[email protected]>

* fix: Xcode 12 compatibility

Co-authored-by: Dan Tamas <[email protected]>
Co-authored-by: Dan Tamas <[email protected]>
* fix overlay bounds confliction from array

* removed auto generated files that are unnecessary

Co-authored-by: Ismail Sener <[email protected]>
…3538)

Improved correctness of documentation by adding key prop to Marker component, rendered via an array mapping. This is as per React guidelines on rendering Lists: https://reactjs.org/docs/lists-and-keys.html#keys

Co-authored-by: Christopher Dro <[email protected]>
* Add key prop to <Marker /> docs

* Changed the description to key prop
* pass camera move's reason to js (android)

* IOS implementation

* renamed value to isGesture

* pretiffied

* doc updated

Co-authored-by: machou <[email protected]>
)

* adding rnc-archive git issue templates

* Delete old ISSUE_TEMPLATE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.