Skip to content

Conversation

@tcompa
Copy link
Collaborator

@tcompa tcompa commented Jan 16, 2025

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@jluethi
Copy link
Collaborator

jluethi commented Jan 16, 2025

Hmm, is the scmultiplex manifest not up to date in its repo?

@jluethi jluethi mentioned this pull request Jan 16, 2025
1 task
@jluethi
Copy link
Collaborator

jluethi commented Jan 16, 2025

Should get fixed by fmi-basel/gliberal-scMultipleX#130

@tcompa
Copy link
Collaborator Author

tcompa commented Jan 17, 2025

Should get fixed by fmi-basel/gliberal-scMultipleX#130

I confirm that our test passes when using the add_manifest_ci branch of scmultiplex (ref https://github.com/fractal-analytics-platform/fractal-tasks-core/actions/runs/12824682381/job/35761236075?pr=899).

I reverted it to main, and then the current PR test will fail until the scmultiplex PR is merged.

@tcompa tcompa merged commit 1728257 into main Jan 17, 2025
@tcompa tcompa deleted the fix-scmultiplex-installation branch January 17, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants