Skip to content

Conversation

@tcompa
Copy link
Collaborator

@tcompa tcompa commented Mar 18, 2025

This is in principle ready, but we may want to review when to merge&release (depending on whether/when additional changes to fractal-tasks-tools are planned).

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@tcompa tcompa linked an issue Mar 18, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

@tcompa tcompa marked this pull request as draft March 19, 2025 10:55
@tcompa
Copy link
Collaborator Author

tcompa commented Mar 19, 2025

cc @jluethi @lorenzocerrone

This was the change I mentioned, about simplifying the GitHub Action step that checks that the manifest did not change: c6991ae

And here is an example where I intentionally made it fail: https://github.com/fractal-analytics-platform/fractal-tasks-core/actions/runs/13944841477/job/39029558855


INFO:root:[check_manifest] package_name='fractal_tasks_core'
INFO:root:[check_manifest] os.getcwd()='/home/runner/work/fractal-tasks-core/fractal-tasks-core'
INFO:root:[check_manifest] package_root_dir=PosixPath('/home/runner/work/fractal-tasks-core/fractal-tasks-core/fractal_tasks_core')
INFO:root:[check_manifest] manifest_path='/home/runner/work/fractal-tasks-core/fractal-tasks-core/fractal_tasks_core/__FRACTAL_MANIFEST__.json'
ERROR:root:[check_manifest] On-disk manifest is not up to date.
ERROR:root:manifest['task_list'][0]['tags'][0] Values are different:
	Old: 'Yokogawa-fixme'
	New:'Yokogawa'
New/old manifests differ

@jluethi
Copy link
Collaborator

jluethi commented Mar 19, 2025

That's great!

I also reviewed the overall PR. It looks good to me overall.

The only addition: The deprecation message could be a bit more explicit:
"This function is deprecated and will be removed in a future release of fractal-tasks-core. Please migrate to fractal-task-tools for manifest building and task wrappers."

If we have a specific transition documentation ready (see comment in fractal-analytics-platform/fractal-task-tools#14), we should directly link to that.

@tcompa tcompa changed the base branch from main to dev-1.5 March 26, 2025 09:57
@tcompa tcompa changed the title [DO NOT MERGE] Switch to fractal-task-tools and deprecate current tools from fractal-tasks-core Switch to fractal-task-tools and deprecate current tools from fractal-tasks-core Mar 26, 2025
@tcompa tcompa marked this pull request as ready for review March 26, 2025 10:37
@tcompa tcompa merged commit ab8d952 into dev-1.5 Mar 26, 2025
@tcompa tcompa deleted the 921-switch-to-fractal-task-tools branch March 26, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to fractal-task-tools

3 participants