-
Notifications
You must be signed in to change notification settings - Fork 7
Switch to fractal-task-tools and deprecate current tools from fractal-tasks-core
#923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
This was the change I mentioned, about simplifying the GitHub Action step that checks that the manifest did not change: c6991ae And here is an example where I intentionally made it fail: https://github.com/fractal-analytics-platform/fractal-tasks-core/actions/runs/13944841477/job/39029558855 |
|
That's great! I also reviewed the overall PR. It looks good to me overall. The only addition: The deprecation message could be a bit more explicit: If we have a specific transition documentation ready (see comment in fractal-analytics-platform/fractal-task-tools#14), we should directly link to that. |
fractal-task-tools and deprecate current tools from fractal-tasks-corefractal-task-tools and deprecate current tools from fractal-tasks-core
This is in principle ready, but we may want to review when to merge&release (depending on whether/when additional changes to
fractal-tasks-toolsare planned).Checklist before merging
CHANGELOG.md