Skip to content

fix #929 #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025
Merged

fix #929 #930

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81128fa
fix #929
lorenzocerrone Apr 3, 2025
31d0876
run pre-commit
lorenzocerrone Apr 3, 2025
9f8ef21
update change log
lorenzocerrone Apr 3, 2025
60e2a8b
Update CHANGELOG.md [skip ci]
tcompa Apr 3, 2025
cccfa75
Update CHANGELOG.md [skip ci]
tcompa Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
**Note**: Numbers like (\#123) point to closed Pull Requests on the fractal-tasks-core repository.

# 1.4.4

* Testing:
* Fix links to ome/ngff specs (\#930).

# 1.4.3

* Tasks:
Expand Down
10 changes: 7 additions & 3 deletions tests/tasks/_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,15 @@


def validate_schema(*, path: str, type: str):

if __OME_NGFF_VERSION__ != "0.4":
raise ValueError(
"This test is only valid for OME-NGFF version 0.4, "
"please update the test."
)
file_path = pooch.retrieve(
url=(
"https://raw.githubusercontent.com/ome/ngff/main/"
f"{__OME_NGFF_VERSION__}/schemas/{type}.schema"
"https://raw.githubusercontent.com/ome/ngff/"
f"7ac3430c74a66e5bcf53e41c429143172d68c0a4/schemas/{type}.schema"
),
known_hash=None,
)
Expand Down
10 changes: 8 additions & 2 deletions tests/test_unit_channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,16 @@ def test_get_channel_from_list(testdata_path: Path):

@pytest.fixture(scope="session")
def omero_channel_schema():

if __OME_NGFF_VERSION__ != "0.4":
raise ValueError(
"This test is only valid for OME-NGFF version 0.4, "
"please update the test."
)
file_path = pooch.retrieve(
url=(
"https://raw.githubusercontent.com/ome/ngff/main/"
f"{__OME_NGFF_VERSION__}/schemas/image.schema"
"https://raw.githubusercontent.com/ome/ngff/"
"7ac3430c74a66e5bcf53e41c429143172d68c0a4/schemas/image.schema"
),
known_hash=None,
)
Expand Down