cellvoager converter fixes #953

jluethi · 2025-05-15T15:35:13Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md

github-actions · 2025-05-15T15:42:16Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_tasks_core
__init__.py	$This PR doesn't change the number of statements in fractal_tasks_core/__init__.py, which is 5.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_tasks_core/__init__.py, which is 100% (5/5).$	$In this PR, 1 new statements are added to fractal_tasks_core/__init__.py, 1 of which are covered (100%).$
channels.py	$This PR adds 1 to the number of statements in fractal_tasks_core/channels.py, taking it from 190 to 191.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/channels.py, which is 1.$	$This PR adds 0.00 percentage points to the coverage rate in fractal_tasks_core/channels.py, taking it from 98.84% (189/190) to 98.85% (190/191).$	$This PR does not seem to add statements to fractal_tasks_core/channels.py.$
fractal_tasks_core/cellvoyager
metadata.py	$This PR adds 6 to the number of statements in fractal_tasks_core/cellvoyager/metadata.py, taking it from 125 to 131.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/cellvoyager/metadata.py, which is 8.$	$This PR adds 0.49 percentage points to the coverage rate in fractal_tasks_core/cellvoyager/metadata.py, taking it from 89.57% (117/125) to 90.05% (123/131).$	$This PR does not seem to add statements to fractal_tasks_core/cellvoyager/metadata.py.$
fractal_tasks_core/tasks
cellvoyager_to_ome_zarr_init.py	$This PR adds 2 to the number of statements in fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init.py, taking it from 167 to 169.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init.py, which is 17.$	$This PR adds 0.11 percentage points to the coverage rate in fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init.py, taking it from 87.78% (150/167) to 87.89% (152/169).$	$This PR does not seem to add statements to fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init.py.$
cellvoyager_to_ome_zarr_init_multiplex.py	$This PR adds 3 to the number of statements in fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init_multiplex.py, taking it from 206 to 209.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init_multiplex.py, which is 21.$	$This PR adds 0.16 percentage points to the coverage rate in fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init_multiplex.py, taking it from 86.15% (185/206) to 86.31% (188/209).$	$This PR does not seem to add statements to fractal_tasks_core/tasks/cellvoyager_to_ome_zarr_init_multiplex.py.$
Project Total

_{This report was generated by python-coverage-comment-action}

jluethi · 2025-05-15T16:02:40Z

Also closes #819

jluethi · 2025-05-15T16:19:27Z

Also includes #843 now.

APX external manifest creation testing appears to fail, I'll deactivate it for the time being and we can check out later whether it remains an issue.

jluethi added 3 commits May 15, 2025 17:11

Improve window handling in converter (closes #952)

c34237c

Improve error logging for multiplexing converter (closes #951)

f5619fc

Update manifest

cbecce7

This was linked to issues May 15, 2025

In Yokogawa converter, ensure Window is set #952

Closed

Improve error message #951

Closed

jluethi added 2 commits May 15, 2025 17:56

Pre-commit fix

ea39eaa

Fix acquisition sorting in multiplexing converter

8fd5796

jluethi linked an issue May 15, 2025 that may be closed by this pull request

Ensure correct ordering of acquisition in multiplexing converter #819

Closed

jluethi added 3 commits May 15, 2025 18:19

Deactivate apx manifest building testing

2aada92

Add string sanitisation for plate names

e45de1c

Fix string sanitisation

8364db0

jluethi linked an issue May 15, 2025 that may be closed by this pull request

Normalize plate names in Cellvoyager converter #843

Closed

Update Changelog

a36fca0

jluethi merged commit c4fb76c into main May 15, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cellvoager converter fixes #953

cellvoager converter fixes #953

Uh oh!

jluethi commented May 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 15, 2025 •

edited

Loading

Uh oh!

jluethi commented May 15, 2025

Uh oh!

jluethi commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cellvoager converter fixes #953

cellvoager converter fixes #953

Uh oh!

Conversation

jluethi commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist before merging

Uh oh!

github-actions bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Uh oh!

jluethi commented May 15, 2025

Uh oh!

jluethi commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jluethi commented May 15, 2025 •

edited

Loading

github-actions bot commented May 15, 2025 •

edited

Loading