Skip to content

970 race conditions #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

970 race conditions #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaec873
Catch FileNotFoundError in Apply registration task
jluethi Aug 4, 2025
2a6317f
Update changelog
jluethi Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
**Note**: Numbers like (\#123) point to closed Pull Requests on the fractal-tasks-core repository.

# Unreleased
* Tasks:
* Catch `FileNotFoundError` in `apply_registration_to_image` task when race conditions with the reference cycle are hit (\#971).

# 1.5.4
* Dependencies:
* Pin `lxml` to `<=5.4.0` (\#963).
Expand Down
1 change: 1 addition & 0 deletions fractal_tasks_core/tasks/apply_registration_to_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,12 @@
current_round = max_retries
curr_table = ad.read_zarr(table_dict[table])
break # Exit loop on success
except (
zarr.errors.GroupNotFoundError,
zarr.errors.PathNotFoundError,
FileNotFoundError,
):
logger.debug(

Check notice on line 223 in fractal_tasks_core/tasks/apply_registration_to_image.py

View workflow job for this annotation

GitHub Actions / Coverage

Missing coverage 

Missing coverage on lines 218-223
f"Table {table} not found in attempt {current_round}. "
f"Waiting {sleep_time} seconds before trying again."
)
Expand Down
Loading