Add deprecation warnings for deprecated patterns#139
Merged
fractaledmind merged 6 commits intomainfrom Jan 25, 2026
Merged
Conversation
- Add AcidicJob.deprecator using ActiveSupport::Deprecation - Deprecate halt_step! in favor of halt_workflow! - Deprecate workflow definitions without 'steps' key - Deprecate old 'FINISHED' recovery point value All deprecated features will be removed in AcidicJob 1.1.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds proper deprecation warnings for features that will be removed in AcidicJob 1.1, replacing TODO comments with actual deprecation infrastructure.
Changes:
- Added
AcidicJob.deprecatorusingActiveSupport::Deprecationfor standardized deprecation warnings - Added deprecation warnings for the old workflow definition format (without 'steps' key)
- Added deprecation warning for the old 'FINISHED' recovery point value
- Added deprecation warning for
halt_step!method in favor ofhalt_workflow!
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/acidic_job.rb | Added deprecator class method that creates an ActiveSupport::Deprecation instance for version 1.1 |
| lib/acidic_job/workflow.rb | Added deprecation warnings for workflows without 'steps' key and for halt_step! method |
| app/models/acidic_job/execution.rb | Added deprecation warnings for old 'FINISHED' recovery point value and workflows without 'steps' key |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Add AcidicJob.serializable_transaction_max_retries config (default: 3) - Add SerializableTransactionRetriesExhaustedError - Extract find_or_create_execution method with built-in retry logic - Catch ActiveRecord::SerializationFailure and ActiveRecord::Deadlocked - Implement exponential backoff (50ms, 100ms, 200ms, etc.) Resolves #91
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All deprecated features will be removed in AcidicJob 1.1.