-
Notifications
You must be signed in to change notification settings - Fork 167
add PG Materialized View to optimize prometheus aggregator queries #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olamilekan000
wants to merge
1
commit into
main
Choose a base branch
from
add-materilized-views-for-prom-aggregatoion-queries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add PG Materialized View to optimize prometheus aggregator queries #2523
olamilekan000
wants to merge
1
commit into
main
from
add-materilized-views-for-prom-aggregatoion-queries
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9819daf to
0e488b2
Compare
jirevwe
reviewed
Jan 6, 2026
jirevwe
reviewed
Jan 6, 2026
jirevwe
reviewed
Jan 6, 2026
Comment on lines
40
to
71
| CREATE MATERIALIZED VIEW IF NOT EXISTS convoy.event_queue_backlog_metrics_mv AS | ||
| WITH a1 AS ( | ||
| SELECT ed.project_id, | ||
| COALESCE(e.source_id, 'http') AS source_id, | ||
| EXTRACT(EPOCH FROM (NOW() - MIN(ed.created_at))) AS age_seconds | ||
| FROM convoy.event_deliveries ed | ||
| LEFT JOIN convoy.events e ON e.id = ed.event_id | ||
| WHERE ed.status = 'Processing' | ||
| GROUP BY ed.project_id, e.source_id | ||
| LIMIT 1000 -- samples | ||
| ) | ||
| SELECT * FROM a1 | ||
| UNION ALL |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using UNION ALL here and in other queries might create duplicate entries when processing queue is empty
jirevwe
reviewed
Jan 6, 2026
Collaborator
|
We should run (using EXPLAIN ANALYSE) these queries against the US prod db to verify they use an index on the event deliveries table. |
jirevwe
reviewed
Jan 6, 2026
09d0870 to
0e488b2
Compare
0e488b2 to
c4269a8
Compare
c4269a8 to
219fa5e
Compare
219fa5e to
faa52af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In production environments with large datasets, Prometheus metrics collection was timing out due to expensive aggregation queries running directly against large tables. The queries were taking longer than the configured timeout, resulting in failed metric collections and incomplete monitoring data.
This often results into error like
Solution
This PR introduces Materialized Views for metrics collection to significantly improve query performance, along with a configurable query timeout.