Make it way more obvious that objects need unique identifiers#3
Open
Make it way more obvious that objects need unique identifiers#3
Conversation
dchester
reviewed
Aug 13, 2021
test/auto.js
Outdated
|
|
||
| let doc3 = AutoPigeon.applyChanges(doc1, c1); | ||
|
|
||
| assert(JSON.stringify(doc3.log) === JSON.stringify(changed)); |
Contributor
There was a problem hiding this comment.
Let's use assert.deepEqual here?
dchester
reviewed
Aug 13, 2021
| function _objId(x) { | ||
| if (_typeof(x) == 'object') { | ||
| const id = x.id || x._id; | ||
| const id = x.id || x._id || x.uuid || x._uuid; |
Contributor
There was a problem hiding this comment.
Wondering if we can allow for for the user to specify/override their own function here...
Contributor
Author
There was a problem hiding this comment.
I really like that idea, but when I started to think about it it didn't seem at all obvious where to pass in that option -- the static from method seems not really right, and there doesn't seem to be another spot where we initialize.
Maybe that's something we should change though? It would be nice to be able to pass in options for history length too.
Contributor
There was a problem hiding this comment.
I tried a take on this in custom-id-function branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.