Upgrade to pg13 & mruby 3.0 (w/ load_avg script)#15
Open
Spaceghost wants to merge 2 commits intofranckverrot:masterfrom
Open
Upgrade to pg13 & mruby 3.0 (w/ load_avg script)#15Spaceghost wants to merge 2 commits intofranckverrot:masterfrom
Spaceghost wants to merge 2 commits intofranckverrot:masterfrom
Conversation
update for pg13 and mruby 3.0 and add a load_average.rb script
franckverrot
requested changes
Jun 20, 2022
Owner
franckverrot
left a comment
franckverrot
left a comment
There was a problem hiding this comment.
Thanks for this MR! Added some comments, I'm not entirely sure why they happened.
Also, why are we removing the Dockerfile and test scripts?
Thanks again.
| @@ -0,0 +1,36 @@ | |||
| # DROP EXTENSION holycorn CASCADE; | |||
Owner
There was a problem hiding this comment.
Could we move this to the examples directory?
| case MRB_TT_EXCEPTION: | ||
| elog(ERROR, "MRB_TT_EXCEPTION not supported (yet?)"); | ||
| break; | ||
| case MRB_TT_FILE: |
Owner
There was a problem hiding this comment.
What has motivated that change?
| slot->tts_nvalid = RARRAY_LEN(output); | ||
|
|
||
| slot->tts_isempty = false; | ||
| // slot->tts_isempty = false; |
Owner
There was a problem hiding this comment.
Any particular reason for this commenting?
|
|
||
| if (slot->tts_nvalid <= 0) { //TODO: the size can't be < 0 but being defensive is OK :-) | ||
| slot->tts_isempty = true; | ||
| // slot->tts_isempty = true; |
| PG_CPPFLAGS = -g -Ivendor/mruby/include -lm | ||
| EXTENSION = holycorn | ||
| SHLIB_LINK = vendor/mruby/build/i686-pc-linux-gnu/lib/libmruby.a vendor/mruby/build/i686-pc-linux-gnu/mrbgems/mruby-redis/hiredis/libhiredis.a | ||
| SHLIB_LINK = vendor/mruby/build/host/lib/libmruby.a |
Owner
There was a problem hiding this comment.
Why are we removing support for mruby-redis?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Can I get a review on these upgrades and help usher a release along?
I'm interested in contributing to this project and offering some additions I'd like to work on.
~spaceghost