Skip to content

feat(agents): trigger multi-agent execution after task approval #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankbria merged 8 commits into from
Jan 11, 2026

fix(e2e): handle shared project state in serial test suite

92cbe18
Select commit
Loading
Failed to load commit list.
Merged

feat(agents): trigger multi-agent execution after task approval #246

fix(e2e): handle shared project state in serial test suite
92cbe18
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Jan 11, 2026 in 38s

No issues identified (2 code objects reviewed).

• Merge Base: 7b8257d
• Head: 92cbe18

Details

✅ File Path Comments Posted
✅ codeframe/ui/routers/tasks.py 0

Filtered Issues Details

codeframe/ui/routers/tasks.py
  • line 98: If lead_agent.start_multi_agent_execution() returns None, the subsequent summary.get('completed', 0) calls will raise AttributeError: 'NoneType' object has no attribute 'get'. While this is caught by the generic exception handler at line 119, it would incorrectly broadcast a development_failed message with a confusing error like 'NoneType' object has no attribute 'get' even though the execution may have completed successfully. The code should guard against None return values, e.g., summary = summary or {}. [ Already posted ]
  • line 357: When ANTHROPIC_API_KEY is not set, the function logs a warning but still returns TaskApprovalResponse with success=True and message Successfully approved {N} tasks. Development phase started. This is misleading because while the phase did transition to active and tasks were approved, no agents will actually be created or execute. Users may wait indefinitely for development progress that will never occur. [ Out of scope ]
View more details on MacroscopeApp