Add flake8 linter and isort workflow to aucmedi #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add flake8 with config for code sytle linting - add isort with config for import sorting
- lint automl/block_eval and pred - replace nested if else with match case
- rerun isort to fix import order errors - update flake8 workflow to run correct command
Member
|
Really nice contribution, thank you very much for that awesome code quality improvement! One thing: AUCMEDI officially supports the latest NumPy stable Python version -> 3.9 right now. We plan to integrate the PR after the dev branch is build stable again (probably next week as @rizoudal is fixing the last two bugs in #227 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flake8 and isort import linter to aucmedi workflows with custom config.