Merged
Conversation
Owner
Author
|
One integration observation is that |
3c8930d to
535c63b
Compare
535c63b to
6f0899b
Compare
antiguru
added a commit
to antiguru/materialize
that referenced
this pull request
Sep 4, 2025
Switch column from sequence to indexed serialization. The difference is that sequence stores data as a sequence of (length, data) and indexed puts all lengths first, followed by all data. We expect this to be more efficient if we do not read all data, or repeatedly borrow its serialized representation. For details, see frankmcsherry/columnar#30 Signed-off-by: Moritz Hoffmann <mh@materialize.com>
antiguru
added a commit
to antiguru/materialize
that referenced
this pull request
Sep 4, 2025
Switch column from sequence to indexed serialization. The difference is that sequence stores data as a sequence of (length, data) and indexed puts all lengths first, followed by all data. We expect this to be more efficient if we do not read all data, or repeatedly borrow its serialized representation. For details, see frankmcsherry/columnar#30 Signed-off-by: Moritz Hoffmann <mh@materialize.com>
antiguru
added a commit
to MaterializeInc/materialize
that referenced
this pull request
Sep 4, 2025
Switch column from sequence to indexed serialization. The difference is that sequence stores data as a sequence of (length, data) and indexed puts all lengths first, followed by all data. We expect this to be more efficient if we do not read all data, or repeatedly borrow its serialized representation. For details, see frankmcsherry/columnar#30 --------- Signed-off-by: Moritz Hoffmann <mh@materialize.com>
antiguru
added a commit
to antiguru/materialize
that referenced
this pull request
Sep 4, 2025
Switch column from sequence to indexed serialization. The difference is that sequence stores data as a sequence of (length, data) and indexed puts all lengths first, followed by all data. We expect this to be more efficient if we do not read all data, or repeatedly borrow its serialized representation. For details, see frankmcsherry/columnar#30 Signed-off-by: Moritz Hoffmann <mh@materialize.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new encoding of a sequence of byte slices, intended to provide more efficient access to the slices when one does not plan on examining all of them. Specifically, to iterate over the byte slices one only has to touch a compact prefix of the memory, in which we record the offsets of each of the slices into the larger memory. This contrasts with the current encoding: a sequence of length delimited byte sequences, which means one must traverse them to find any one slice, or to count their number.
This is a breaking change, as the encoding only works for
A: AsBytes, rather than an iterator over slices. We could extend it to an iterator that supportsclone(), but we need to perform three passes to extract the information (number of offsets, values of the offsets, and the bytes themselves).More testing and integration is needed before this is published.