Allow for general byte slice serialization#31
Merged
frankmcsherry merged 2 commits intomasterfrom Feb 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how we present the encoding and decoding of byte sequences, consolidating the logic behind an
EncodeDecodetrait. This is breaking, in that it removesAsBytes::length_in_words, but this method was inappropriately opinionated about how the type should be serialized. Uses should be replaced withEncodeDecode::lengthinstead.Porting over timely's
examples/columnarto work with the new encoding was short and actually reduced some code.